Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Fixed incorrect reversed condition for GT #92316

Merged
merged 6 commits into from
Sep 21, 2023
Merged

JIT: Fixed incorrect reversed condition for GT #92316

merged 6 commits into from
Sep 21, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Sep 20, 2023 •
edited
Loading

Resolves #92201

GT was getting incorrectly reversed. Looks like an oversight, though it is surprising this wasn't caught sooner. Original code was here since 2018.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 20, 2023
@ghost ghost assigned TIHan Sep 20, 2023
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #92201

GT was getting incorrectly reversed. Looks like an oversight, though it is surprising this wasn't caught sooner.

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

jakobbotsch
jakobbotsch approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@jakobbotsch
Copy link
Member

jakobbotsch commented Sep 20, 2023 •
edited
Loading

GT was getting incorrectly reversed. Looks like an oversight, though it is surprising this wasn't caught sooner. Original code was here since 2018.

It's probably very hard to end up with the FGTU unordered floating pointer greater than comparison in the first place, looks like the only possible way is if we reverse a FLE comparison, but then it's probably very unlikely for us to end up reversing it a second time to hit the bug.
So it might be very hard to come up with a test.

@TIHan TIHan merged commit b2417c3 into dotnet:main Sep 21, 2023
137 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
@kunalspathak kunalspathak mentioned this pull request Mar 27, 2024
Closed
@kunalspathak
Copy link
Member

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8458964624

@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@TIHan TIHan

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure _Vector128_ro::JIT.HardwareIntrinsics.General._Vector128.Program.LessThanOrEqualAnySingle()
3 participants
@TIHan @jakobbotsch @kunalspathak