Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-rc2][wasm] Add a dependency on dotnet/installer to get the latest #92353

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[release/8.0-rc2][wasm] Add a dependency on dotnet/installer to get the latest #92353

merged 3 commits into from
Sep 20, 2023

Conversation

radical
Copy link
Member

@radical radical commented Sep 20, 2023 •
edited
Loading

And update version from .NET 8.0.1xx SDK channel.

(cherry picked from commit c821c36)

This is a tests only change.

Customer Impact

None, as this is a tests only change.

Testing

CI run

Risk

None, tests only change.

@radical
[wasm] Add a dependency on dotnet/installer to get the latest
eb59e4f 
And update version from `.NET 8.0.1xx SDK` channel.

(cherry picked from commit c821c36)
@ghost ghost assigned radical Sep 20, 2023
@radical radical changed the title [wasm] Add a dependency on dotnet/installer to get the latest [release/8.0-rc2][wasm] Add a dependency on dotnet/installer to get the latest Sep 20, 2023
@radical radical added the arch-wasm WebAssembly architecture label Sep 20, 2023
@radical radical marked this pull request as draft September 20, 2023 16:59
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

And update version from .NET 8.0.1xx SDK channel.

(cherry picked from commit c821c36)

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono
Milestone: -

@radical radical marked this pull request as ready for review September 20, 2023 20:56
@radical radical added the Servicing-consider Issue for next servicing release review label Sep 20, 2023
@radical
Copy link
Member Author

radical commented Sep 20, 2023

@carlossanlop This is a tests only change. Do I need send an email to tactics?

@radical radical mentioned this pull request Sep 20, 2023
Closed
carlossanlop
carlossanlop approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tests only change. Do I need send an email to tactics?

@radical nope, tell mode. You got my approval.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 20, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 20, 2023
@carlossanlop carlossanlop merged commit 58eb21d into dotnet:release/8.0-rc2 Sep 20, 2023
180 of 187 checks passed
@radical radical deleted the wbt-sdk-unpin-8-rc2 branch September 20, 2023 22:55
@radical radical mentioned this pull request Sep 26, 2023
Closed
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing Awaiting requested review from lewing

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@kg kg Awaiting requested review from kg

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @carlossanlop