Provide ALC name in DispatchProxy for proxies in custom ALC #92385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFixes #82969
|
This was referenced Sep 21, 2023
jkotas
reviewed
Sep 21, 2023
| @@ -86,7 +86,6 @@ public void Ctor_String_Public_Key(string name, string expectedName) | |||
| [InlineData("", typeof(ArgumentException))] | |||
| [InlineData("\0", typeof(ArgumentException))] | |||
| [InlineData("\0a", typeof(ArgumentException))] | |||
| [InlineData("/a", typeof(FileLoadException))] | |||
There was a problem hiding this comment.
These tests should be replaced by positive tests
jkotas
reviewed
Sep 21, 2023
src/coreclr/vm/assembly.cpp
Outdated
| || u16_strchr(pAssemblyNameParts->_pName, '\\') != NULL | ||
| || u16_strchr(pAssemblyNameParts->_pName, ':') != NULL | ||
| || u16_strchr(pAssemblyNameParts->_pName, '/') != NULL) | ||
| if (COMCharacter::nativeIsWhiteSpace(pAssemblyNameParts->_pName[0])) |
This was referenced Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82969