[release/8.0-rc2] Ensure Bind can handle null from GetSection #92477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
IConfiguration instances may return a null value from GetSection. We were not handling this and would throw a NullReferenceException.
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #92384 to release/8.0-rc2 /cc @ericstj Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tarekgh
approved these changes
Sep 22, 2023
artl93
approved these changes
Sep 22, 2023
|
M2 approved. |
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
|
Thank you @carlossanlop |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92384 to release/8.0-rc2
/cc @ericstj
Customer Impact
NullReferenceException when an IConfiguration instance returns
nullfromGetSection. No implementations in the product do this, and the interface is not annotated to return null, however we received a customer report of this regression from mocking the interface. When usingmoqto mock an interface it will return null for unspecified cases.Testing
Tested customer reported case manually using Moq. Added automated test for both runtime binder and source gen to catch this behavior.
Risk
Very low - we are only adding back a null check that was removed from a previous change in RC2.