Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nullability check for generic .ctor parameters #92514

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Improve nullability check for generic .ctor parameters #92514

merged 5 commits into from
Sep 26, 2023

Commits on Sep 23, 2023

  1. implement absent generic ctor param check

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    b62f167 View commit details
    Browse the repository at this point in the history

  2. fix code style

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8a03bbb View commit details
    Browse the repository at this point in the history

  3. Improve nullability check for generic parameters in ctor 

    `NullabilityInfoContext.CheckParameterMetadataType` didn't have
code paths for parameters in constructors, leading to wrong
nullability results.

The PR adds a code path for constructor parameters.

Fix dotnet#92487
    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    31afd2a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. add tests on nullability of ctors and methods with generic parameters

    @karakasa
    karakasa committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    440f99e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. fix test issues with AOT trimming

    @karakasa
    karakasa committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2ea7f5e View commit details
    Browse the repository at this point in the history