Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix LLVMAOT Mono runtime variant official build to produce correctly named runtime packs #92737

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #92712 to release/8.0

/cc @steveisok @akoeplinger

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

…named runtime packs

In 75ee623 the condition in src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.props got changed from checking `MonoBundleLLVMOptimizer` to `MonoAOTEnableLLVM` but we weren't setting that property in runtime-official.yml so both jobs produced runtime packs with the same suffix, resulting in the artifact uploads randomly overwriting each other.
@ghost
Copy link

ghost commented Sep 27, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92712 to release/8.0

/cc @steveisok @akoeplinger

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok steveisok changed the base branch from release/8.0 to release/8.0-rc2 September 27, 2023 18:41
@steveisok steveisok self-requested a review September 27, 2023 18:44
@steveisok steveisok changed the base branch from release/8.0-rc2 to release/8.0 September 27, 2023 18:52
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 27, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Sep 27, 2023

@akoeplinger @steveisok just to confirm -

  • I see two target branch changes. Is release/8.0 the correct one?
  • Do you need me to merge without waiting for the CI to finish?

@steveisok
Copy link
Member

Yes, release/8.0 is the correct one. And yes, please merge w/o waiting for CI.

@carlossanlop carlossanlop merged commit 56749c5 into release/8.0 Sep 27, 2023
39 of 150 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92712-to-release/8.0 branch September 27, 2023 19:14
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants