Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment with min OS version locations to update #93180

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

akoeplinger
Copy link
Member

Discovered another version we need to keep in sync in #93167

Discovered another version we need to keep in sync in #93167
@ghost
Copy link

ghost commented Oct 7, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Discovered another version we need to keep in sync in #93167

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure-libraries

Milestone: -

@@ -58,6 +58,7 @@
- src/installer/pkg/sfx/bundle/shared-framework-distribution-template-x64.xml
- src/installer/pkg/sfx/bundle/shared-framework-distribution-template-arm64.xml
- src/tasks/MobileBuildTasks/Apple/AppleProject.cs
- dotnet/installer repo > src/redist/targets/GeneratePKG.targets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unused watchOSVersionMin and watchOS64_32VersionMin and add them when needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost
Copy link

ghost commented Oct 8, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Discovered another version we need to keep in sync in #93167

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure

Milestone: -

@akoeplinger akoeplinger merged commit f020861 into main Oct 8, 2023
3 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch October 8, 2023 09:07
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants