Commits on Oct 12, 2023

1. Explicitly represent BBJ_EHFINALLYRET successors …

   Currently, BBJ_EHFINALLYRET blocks have no explicit successors in the IR.
   To implement successor iteration, a very expensive process is followed to
   (1) find the region of blocks where a BBJ_CALLFINALLY block calling the
   `finally` might be found, (2) search the region for such blocks, and (3)
   return as a successor all the BBJ_ALWAYS blocks in the corresponding
   BBJ_CALLFINALLY/BBJ_ALWAYS pair.
   
   Change the IR to explicitly represent and maintain this list of successors
   for BBJ_EHFINALLYRET blocks. The representation is a simple array of
   `BasicBlock*`, similar to how BBJ_SWITCH block targets are represented.
   
   Fixes dotnet#84278
   
   Notes:
   1. The BBJ_EHFINALLYRET successors are computed in `impFixPredLists()`.
   There are various dumpers that run before this, so we need to tolerate
   incomplete successor information in some places.
   2. `ehGetCallFinallyBlockRange()` is still used by some code. I changed the
   semantics to return a `[first..last]` range inclusive of `last` instead of
   the previous `[beginning..end)` range exclusive of `end`. This makes it easier
   to use with our BasicBlock iterators.

   

   BruceForstall committed Oct 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e039bd6
   • Browse repository at this point

   Copy the full SHA

   e039bd6 View commit details

   Browse the repository at this point in the history

2. Review suggestions

   

   BruceForstall committed Oct 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c75942e
   • Browse repository at this point

   Copy the full SHA

   c75942e View commit details

   Browse the repository at this point in the history