hosting windows service helper enhancement #93771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue Detailsfixes #93613
|
huoyaoyuan
reviewed
Oct 20, 2023
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceHelpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceHelpers.cs
Outdated
Show resolved
Hide resolved
|
I wonder if we can convert |
Not sure how it affects trimming but, using if (
#if NETFRAMEWORK
Environment.OSVersion.Platform != PlatformID.Win32NT
#elif NET5_0_OR_GREATER
!OperatingSystem.IsWindows()
#else
!RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
#endif
)
{
return false;
} |
using OperatingSystem for net 5.0 or greater
WeihanLi
added a commit
to WeihanLi/runtime
that referenced
this pull request
Oct 30, 2023
align code style with dotnet#93771
stephentoub
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Update SystemdHelpers.cs align code style with #93771 * Update SystemdHelpers.cs revert OperationSystem condition change * remove partial on SystemdHelpers
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #93613