Annotate projects that aren't XML source of truth #94234
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailswith the
|
ViktorHofer
force-pushed
the
MakeXMLSourceOfTruthClear
branch
from
8d5852c
to
bc2ab84
Compare
with the `UseCompilerGeneratedDocXmlFile` switch.
ViktorHofer
force-pushed
the
MakeXMLSourceOfTruthClear
branch
from
bc2ab84
to
c90dcc8
Compare
| @@ -41,12 +42,13 @@ System.Threading.RateLimiting.RateLimitLease</PackageDescription> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'"> | |||
There was a problem hiding this comment.
Is there any advantage on switching their locations here?
Also, if they are ItemGroups with the exact same condition, wouldn't it be ok to group both ItemGroups into a single one?
There was a problem hiding this comment.
Our convention is properties first, then compile and other items and last reference items. Keeping the reference items in a separate item group makes it easier to read a project's dependencies.
| @@ -1,29 +1,14 @@ | |||
| <Project> | |||
|
|
|||
| <PropertyGroup> | |||
| <UseCompilerGeneratedDocXmlFile Condition="'$(UseCompilerGeneratedDocXmlFile)' == '' and $(MSBuildProjectName.StartsWith('Microsoft.Extensions.'))">true</UseCompilerGeneratedDocXmlFile> | |||
There was a problem hiding this comment.
Ok I see. If true is treated as default, then all assemblies, except Cbor and Extensions, need the property explicitly mentioned in the csprojs.
ghost
locked as resolved and limited conversation to collaborators
with the
UseCompilerGeneratedDocXmlFileswitch.