Add some sanity checking for SPMI JIT options arguments #94248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the argument passed doesn't include a leading `DOTNET_`. Update the help to specify the allowed `key#value` format. Currently using `DOTNET_` causes a warning, but arguably superpmi.py should just pass it through and superpmi.exe should just strip the prefix, so it would "just work".
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCheck that the argument passed doesn't include a leading Update the help to specify the allowed Currently using
|
|
@jakobbotsch PTAL |
|
I was confused for a while when something I tried didn't cause any spmi replay errors, and it's because I was passing |
This was referenced Nov 1, 2023
jakobbotsch
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the argument passed doesn't include a leading
DOTNET_.Update the help to specify the allowed
key#valueformat.Currently using
DOTNET_causes a warning, but arguably superpmi.py should just pass it through and superpmi.exe should just strip the prefix, so it would "just work".