Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for R2R configured runs. #94412

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add option for R2R configured runs. #94412

merged 1 commit into from
Nov 7, 2023

Conversation

cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Nov 6, 2023 •
edited
Loading

@cincuranet cincuranet self-assigned this Nov 6, 2023
@ghost
Copy link

ghost commented Nov 6, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Depends on dotnet/performance#3467.

Author: cincuranet
Assignees: cincuranet
Labels:

area-Infrastructure-libraries
Milestone: -

LoopedBard3
LoopedBard3 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there plans to also make updates to perf-job.yml and run-performance-job.yml so that we don't have naming collisions for these runs? I don't have strong feelings for it being done here vs another commit regardless.

@cincuranet
Copy link
Contributor Author

cincuranet commented Nov 7, 2023 •
edited
Loading

Better to do it in one PR. PR updated.

LoopedBard3
LoopedBard3 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cincuranet cincuranet merged commit 2801995 into dotnet:main Nov 7, 2023
16 of 19 checks passed
@cincuranet cincuranet deleted the r2r-type branch November 7, 2023 18:03
@cincuranet cincuranet added perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines area-Infrastructure and removed area-Infrastructure-libraries labels Nov 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@sblom sblom Awaiting requested review from sblom

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees

@cincuranet cincuranet

Labels
area-Infrastructure perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cincuranet @LoopedBard3