Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Use live M.Bcl.AsyncInterfaces dependency #94459

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 7, 2023

Manual backport of #94451

Customer Impact

Customers who reference the Microsoft.Bcl.TimeProvider polyfill package, transitively reference the 6.0.0 version of the Microsoft.Bcl.AsyncInterfaces package instead of the 8.0.0 version.

Not brining in the old 6.0.0 version is especially important for the .NET deprecation effort. At the time when we will deprecate our 6.0.x packages, we would need to keep AsyncInterfaces un-deprecated as it is referenced by the TimeProvider package.

Testing

Manually produced the package and now seeing the correct 8.0.0 version in the package / nuspec.

Risk

Low. Two msbuild project files are changed. No code changes aside from that.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 7, 2023
@ghost ghost assigned ViktorHofer Nov 7, 2023
@ViktorHofer ViktorHofer added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 7, 2023
@ghost
Copy link

ghost commented Nov 7, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #94451

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-System.DateTime, needs-area-label

Milestone: -

@ViktorHofer ViktorHofer added the Servicing-consider Issue for next servicing release review label Nov 7, 2023
@ViktorHofer ViktorHofer added this to the 8.0.x milestone Nov 7, 2023
@carlossanlop
Copy link
Member

Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete).

@ViktorHofer
Copy link
Member Author

We didn't get Tactics approval as this change can wait until Jan.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 16, 2023
@leecow leecow modified the milestones: 8.0.x, 8.0.2, 8.0.1 Nov 16, 2023
@carlossanlop carlossanlop merged commit 1aa09ef into release/8.0-staging Nov 21, 2023
109 of 114 checks passed
@carlossanlop carlossanlop deleted the ViktorHofer-patch-2 branch November 21, 2023 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.DateTime Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants