Report StackOverflowException on NativeAOT on Linux #94485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow
…ester.cs Co-authored-by: Michal Strehovský <[email protected]>
…cted failures and remove messages about failing to find createdump
Co-authored-by: Jan Vorlicek <[email protected]>
…r/runtime into StackOverflowLinuxNAOT
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
jtschuster
added
area-NativeAOT-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsMoved #93901 here. Pulling main messed up something, so just going to make a new PR. Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException. Fixes #82334 Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.
|
This was referenced Nov 7, 2023
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@MichalStrehovsky Can you take a look and sign off when you get a chance? |
MichalStrehovsky
approved these changes
Nov 13, 2023
jtschuster
added a commit
that referenced
this pull request
Nov 29, 2023
This reverts commit 261668f.
jtschuster
added a commit
that referenced
this pull request
Nov 29, 2023
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
Dec 8, 2023
…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved #93901 here. Pulling main messed up something, so just going to make a new PR.
Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes #82334
Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.