Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bump to two issue while working on #94112
I was using the SSLKEYLOG environment so I can decrypt TLS and peek at the HTTP/2 exchange.
However, often the sessions keys were not there and I failed to decrypt the transaction. It seems like when the handshake happens and the process exist immediately not everything is written. Adding
Flush
seems to fix this.It may come with some perf cost but this is Debug only feature so it should not matter as much.
The issue would happen only when running whole test suite. I wanted to instrument the test to spit out the IPEndPoints so I can find the connection among many in the capture file. So I added
ToString
that can giver me something likeHttp2LoopbackConnection 127.0.0.1:42543 <-> 127.0.0.1:60302
with that I can set filer in Wireshark as
tcp.port==42543
and get