Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISC-V] Initial patch to fix RISCV64 interpreter #94548

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

JongHeonChoi
Copy link
Contributor

@JongHeonChoi JongHeonChoi commented Nov 9, 2023

Initial patch of interpreter for RISCV64 at HelloWorld level.

cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @sirntar @yurai007 @Bajtazar @tomeksowi

@clamp03
Copy link
Member

clamp03 commented Nov 10, 2023

@jkotas We have updated CoreCLR interpreter for RISC-V because I think the interpreter is useful for debugging in our product issue where JITC on RISC-V does not work well. However, I find it has many problems. Cannot compile on x64 and arm64 (before this PR). Cannot run helloworld from the beginning on arm64/x64/riscv64. (It can only run the helloworld main function). So I just wonder, do you have a plan to complete the interpreter? Or will you keep the interpreter as it is now?

@jkotas
Copy link
Member

jkotas commented Nov 10, 2023

We do not have any plans with the CoreCLR interpreter. We know that it is pretty broken.

@clamp03
Copy link
Member

clamp03 commented Nov 10, 2023

Thank you for the comment. Okay. we need to use it very carefully.
Could you review this PR?

@jkotas jkotas merged commit e7ab2f6 into dotnet:main Nov 10, 2023
106 of 111 checks passed
@tomeksowi
Copy link
Contributor

We have updated CoreCLR interpreter for RISC-V because I think the interpreter is useful for debugging in our product issue where JITC on RISC-V does not work well

Could you enumerate the painspots with JITC? Perhaps it could be a starting point for a to-do list of improvements.

@clamp03
Copy link
Member

clamp03 commented Nov 10, 2023

We fixed many bugs in coreclr and corefx unit tests on QEMU and Sifive2 devices.
Next year, we need to start testing, debugging and optimising tizenfx tests and big real applications on tizen riscv devices, which are very unstable environment in both hardware and software. Maybe all crashes and errors would be assigned to us because all crashes and errors occur when tests or applications are running. And as you know, fixing bugs in generated machine codes by JITC is very hard. I am so afraid of this situation. 😢 IMO we need to prepare tools (like createdump, debugging tools and logging tools), tizen risc-v CI and so on. Fixing the CoreCLR interpreter is one of them.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants