Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslStream test keylogfile creation #94859

Merged
merged 2 commits into from
Nov 17, 2023
Merged

SslStream test keylogfile creation #94859

merged 2 commits into from
Nov 17, 2023

Conversation

ManickaP
Copy link
Member

Same as the test added for Quic in #93119

@ghost ghost assigned ManickaP Nov 16, 2023
@ghost
Copy link

ghost commented Nov 16, 2023

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Same as the test added for Quic in #93119

Author: ManickaP
Assignees: ManickaP
Labels:

area-System.Net.Security
Milestone: -

@ManickaP ManickaP requested review from wfurt and rzikm November 16, 2023 17:46
rzikm
rzikm approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wfurt
wfurt approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysis build-analysis bot mentioned this pull request Nov 16, 2023
Closed
@ManickaP
Copy link
Member Author

Failure is #93347

@ManickaP ManickaP merged commit 56cfca1 into dotnet:main Nov 17, 2023
106 of 109 checks passed
@ManickaP ManickaP deleted the mapichov/ssl-test-keylogfile branch November 17, 2023 12:00
ManickaP added a commit to ManickaP/runtime that referenced this pull request Nov 17, 2023
@ManickaP
SslStream fix and test keylogfile creation (dotnet#94859)
0bd83a0 
* Added flushing the secrets
* Added the same test as we have for Quic for SSLKEYLOGFILE creation
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzikm rzikm rzikm approved these changes

@wfurt wfurt wfurt approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Security
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ManickaP @wfurt @rzikm @karelz