Fix performance of System.Security. Cryptography.Tests #95284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the RSA 16384 tests to outerloop. These tests take a significant amount of time on Linux due to primality tests of RSA 16384. These six tests were accounting for over half the time of test suite on my machine.
This also significantly improves the inner-loop dev experience as test discovery is near-instant now instead of taking dozens of seconds.
This also impacted the
RSAOpenSsl
tests on macOS.BEFORE ./dotnet.sh test src/libraries/System.Security.Cryptography/tests 696.78s user 9.53s system 342% cpu 3:25.93 total
AFTER ./dotnet.sh test src/libraries/System.Security.Cryptography/tests 491.88s user 8.50s system 643% cpu 1:23.73 total
Fixes #94436
Fixes #93840