[release/8.0-staging] Add support for enumerating keyed services with KeyedService.AnyKey

[github-actions]

Backport of #95582 to release/8.0-staging

Note that there will be a follow-up PR that will also be backported; see #95582 (comment)

/cc @benjaminpetit

Customer Impact

Keyed services in DI are new in 8.0, and this addresses an issue when KeyService.AnyKey is used when quering via IServiceProvider.GetKeyedServices<IService>(KeyedService.AnyKey).

Previously, registering a keyed service with a null key would show up when calling GetKeyedServices(), now they won't be. When null is used at a key for a service, the service is not considered a keyed service.
 

Testing

Tests were added to the original PR.

Risk

See above; there is some pending follow-up work that should be done in the same versioning release.

Other

• Added <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
• Added <ServicingVersion>1</ServicingVersion>

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #95582 to release/8.0-staging

/cc @benjaminpetit

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[stephentoub]

@benjaminpetit, @steveharter, was mail sent to tactics about this one yet? Thanks.

[halter73]

I don't think we should merge this until we address the bug I describe in #95582 (comment) and add tests for GetKeyedService<IService>(KeyedService.AnyKey) and multiple AnyKey registrations.

[carlossanlop]

The DependencyInjection.csproj is marked as IsPackable=true, meaning it is an OOB package. It needs package authoring changes to ensure it gets built.

Here's the documentation: https://github.com/dotnet/runtime/blob/release/8.0-staging/docs/project/library-servicing.md

[carlossanlop]

Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If the feedback gets addressed, please merge before that date and time to ensure this fix gets included in that Release. Otherwise, it'll have to wait until March.

[benjaminpetit]

I think as pointed in #95582, it needs more work

[carlossanlop]

Friendly reminder that Monday February 12th is the Code Complete deadline for the March Release. If the feedback gets addressed, please merge before that date to ensure this fix gets included in that Release. Otherwise, it'll have to wait until April.

[carlossanlop]

Friendly reminder that Monday March 11th is the Code Complete date for the April Release. If you want this change to be included in that release, please address the remaining blocking feedback, get a sign-off from an area owner, and send an email to Tactics requesting approval. @benjaminpetit @halter73

[stephentoub]

@benjaminpetit, where are we with this?

[steveharter]

@benjaminpetit should we close this PR for now?

[benjaminpetit]

Yes, we first need to reopen and finish #97561 (I don't think we have consensus right now on the right approach)

[robertmclaws]

So is anything happening with this? I would really use it in several of my apps.

[carlossanlop]

@benjaminpetit @halter73 friendly reminder that code complete for the August Release is July 15th. If you want this fix to be included in that release, please merge this PR before that date.

[carlossanlop]

Friendly reminder that Monday July 15th is Code Complete day, that's the deadline to get this included in the August Release.

[carlossanlop]

@halter73 @benjaminpetit this has been open for 8 months, Let's close it and come back to it if we decide we want it fixed.

[robertmclaws]

Can we PLEASE fix this? I have certain scenarios for my apps that don't work properly because AnyKey does not work properly.