[infra] Enable linux-x64 Mono fullAOT mini job on extra platforms #96332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
|
The runtime changes look ok to me. |
matouskozak
reviewed
Mar 8, 2024
eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
Outdated
Show resolved
Hide resolved
| /p:BuildMonoAotCrossCompiler=true | ||
| /p:BuildMonoAotCrossCompilerOnly=true | ||
| /p:MonoLibClang="/usr/local/lib/libclang.so.16" | ||
| /p:MonoAOTEnableLLVM=true |
There was a problem hiding this comment.
Not relevant since this PR is addressing mini full AOT, but I'm not sure if we shouldn't also pass /p:MonoEnableLLVM=true. For Perf AOT-llvm runs we use /p:MonoAOTEnableLLVM=true /p:MonoEnableLLVM=true /p:BuildMonoAOTCrossCompiler=true ... for both x64 and arm64.
There was a problem hiding this comment.
Good point. Based on the source code, the output directory should be different for the LLVM optimizer and the linker when MonoAOTEnableLLVM vs MonoEnableLLVM is used. I suggest to address it in the LLVM-related PR.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 21, 2024
…time into feature/mini-fullaot-job
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 21, 2024
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the linux-x64 full AOT mini job on extra platforms, utilizing the CBL-Mariner docker image. The parameters
as_nameandas_options, along withld_nameandld_optionsare added to allow parameterization of the toolchain configuration.Subsequent PRs include linux-x64 fullAOT llvm job, and arm64 jobs.
Test job run: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=620710&view=logs&jobId=9c845561-93d9-5f12-0979-955ea2f35497