Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using HashSet instead of Dictionary multiple times #96573

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

ndsvw
Copy link
Contributor

@ndsvw ndsvw commented Jan 6, 2024

Replaced occurrences of Dictionary<TKey, TValue> with HashSet<T>.

Inspired by Performance improvements in .Net 8 and #89030.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 6, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 6, 2024
@ndsvw
Copy link
Contributor Author

ndsvw commented Jan 6, 2024

@dotnet-policy-service agree

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@stephentoub stephentoub merged commit 6933285 into dotnet:main Jan 7, 2024
109 of 111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants