[mono] Save trimmed methods list to a file #97705
Conversation
ghost
assigned 
dotnet-issue-labeler
bot
added
the
needs-area-label
| @@ -247,6 +250,7 @@ private static string ComputeGuid(MetadataReader mr) | |||
| int methodToken = MetadataTokens.GetToken(mr, mdefh); | |||
| MethodDefinition mdef = mr.GetMethodDefinition(mdefh); | |||
| int rva = mdef.RelativeVirtualAddress; | |||
| string methodName = mr.GetString(mdef.Name); | |||
There was a problem hiding this comment.
this isn't the full name of the method (ie: NameSpace.ClassName+NestedClassName<T,U>.SomeMethod<V,W>(Arg1 arg1, Arg2 arg2, ..., ArgN argN)). It's just SomeMethod. Is that what we want? The file might have 100 methods all named ToString or something.
There was a problem hiding this comment.
You are right. Do you know how to get the method full signature?
There was a problem hiding this comment.
There's not an easy way :-(
you need to get the mdef.GetDeclaringType() which will be a TypeDefinitionHandle. then you need to get the TypeDefinition using mr.GetTypeDefiniton() which will have a Namespace and a Name property. And also you have to get its GetDeclaringType if it's a nested type, and so on until there's no more enclosing types.
That will at least get you enough so you can print SomeNameSpace.SomeClass.SomeEnclosingType.SomeMethodName which is better. (it woudl be good to also print the method signature in case we need to care about overloads, but that's harder)
Is there a way to get the full method signature?
This functionality is not useful for the user as they don't have control over what to trim and what not to trim. This is added to help mono developers to debug potential future issues. |
fanyang-mono
added
area-Codegen-AOT-mono
and removed
needs-area-label
This should give the user a way to know which exact methods got trimmed.