Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VM's copy of daccess.h #97751

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Use VM's copy of daccess.h #97751

merged 3 commits into from
Feb 7, 2024

Conversation

MichalStrehovsky
Copy link
Member

Most of the diffs are caused due to VM's use of Win32 emulator types and AOT's use of standard C types.

Since we don't actually build a DAC, the rest of the diffs don't matter.

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Jan 31, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Most of the diffs are caused due to VM's use of Win32 emulator types and AOT's use of standard C types.

Since we don't actually build a DAC, the rest of the diffs don't matter.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

src/coreclr/inc/daccess.h Outdated Show resolved Hide resolved
src/coreclr/inc/daccess.h Outdated Show resolved Hide resolved
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 6a2a4ac into dotnet:main Feb 7, 2024
108 of 111 checks passed
@MichalStrehovsky MichalStrehovsky deleted the daccess branch February 7, 2024 21:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants