Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][mt] fix WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation #97775

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[browser][mt] fix WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation #97775

merged 1 commit into from
Feb 1, 2024

Conversation

pavelsavara
Copy link
Member

Contributes to #96628

Fix for Log

[16:55:55] info: [STRT] System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation
[16:55:55] info: [0x0513e6d0-jsww 16:55:55.931] MONO_WASM: forceDisposeProxies done: 0 imports, 0 exports, 0 GCHandles, 0 JSHandles.
[16:55:56] fail: [FAIL] System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation
[16:55:56] info: Assert.ThrowsAny() Failure: Exception type was not compatible
[16:55:56] info: Expected: typeof(System.OperationCanceledException)
[16:55:56] info: Actual:   typeof(System.ObjectDisposedException)
[16:55:56] info: ---- System.ObjectDisposedException : Cannot access a disposed object.
[16:55:56] info: Object name: 'System.Runtime.InteropServices.JavaScript.JSSynchronizationContext'.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 31, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 31, 2024
@pavelsavara pavelsavara self-assigned this Jan 31, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #96628

Fix for Log

[16:55:55] info: [STRT] System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation
[16:55:55] info: [0x0513e6d0-jsww 16:55:55.931] MONO_WASM: forceDisposeProxies done: 0 imports, 0 exports, 0 GCHandles, 0 JSHandles.
[16:55:56] fail: [FAIL] System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.JSSynchronizationContext_Send_Post_Items_Cancellation
[16:55:56] info: Assert.ThrowsAny() Failure: Exception type was not compatible
[16:55:56] info: Expected: typeof(System.OperationCanceledException)
[16:55:56] info: Actual:   typeof(System.ObjectDisposedException)
[16:55:56] info: ---- System.ObjectDisposedException : Cannot access a disposed object.
[16:55:56] info: Object name: 'System.Runtime.InteropServices.JavaScript.JSSynchronizationContext'.
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara marked this pull request as ready for review January 31, 2024 18:58
This was referenced Jan 31, 2024
Open
Closed
@pavelsavara pavelsavara merged commit e5cebac into dotnet:main Feb 1, 2024
117 of 121 checks passed
@pavelsavara pavelsavara deleted the browser_mt_improve_tests branch February 1, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @ilonatommy