Ensure that Sse3.MoveAndDuplicate correctly tracks supporting SIMD scalar loads #97783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #97688 by ensuring that
|
|
We may want to consider backporting the fix to .NET 8 given its LTS. Since we're not marking it contained, LSRA assigns the value to a register and may expect it there for a latter use. Where-as codegen currently treats it as contained anyways and consumes the value directly from memory. |
Diff results for #97783Assembly diffsAssembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,517,908 contexts (991,070 MinOpts, 1,526,838 FullOpts). MISSED contexts: 1 (0.00%) Overall (-468 bytes)
MinOpts (-326 bytes)
FullOpts (-142 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,512,209 contexts (997,391 MinOpts, 1,514,818 FullOpts). MISSED contexts: 3 (0.00%) Overall (-468 bytes)
MinOpts (-358 bytes)
FullOpts (-110 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
FullOpts (-0.02% to -0.01%)
Throughput diffs for linux/x64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.01% to -0.00%)
FullOpts (-0.01% to -0.00%)
Throughput diffs for osx/arm64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
FullOpts (-0.02% to -0.01%)
Throughput diffs for windows/arm64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
MinOpts (-0.00% to +0.01%)
FullOpts (-0.02% to -0.01%)
Throughput diffs for windows/x64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.01% to -0.00%)
FullOpts (-0.01% to -0.00%)
Details here |
Diff results for #97783Assembly diffsAssembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,293,451 contexts (839,658 MinOpts, 1,453,793 FullOpts). MISSED contexts: 45 (0.00%) Overall (-542 bytes)
MinOpts (-304 bytes)
FullOpts (-238 bytes)
Details here |
jakobbotsch
approved these changes
Jan 31, 2024
|
@jakobbotsch do you want me to go ahead and backport this to .NET 8? |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8471953595 |
|
@tannergooding backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Ensure that Sse3.MoveAndDuplicate correctly tracks supporting SIMD scalar loads
Using index info to reconstruct a base tree...
M src/coreclr/jit/lowerxarch.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/jit/lowerxarch.cpp
CONFLICT (content): Merge conflict in src/coreclr/jit/lowerxarch.cpp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure that Sse3.MoveAndDuplicate correctly tracks supporting SIMD scalar loads
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@tannergooding an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #97688 by ensuring that
Sse3.MoveAndDuplicatecorrectly tracks supporting SIMD scalar loads so that the necessary containment happens everywhere its expected.