Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT/ARM] Fix trashing r4 register in RhpCallCatchFunclet #97810

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[NativeAOT/ARM] Fix trashing r4 register in RhpCallCatchFunclet #97810

merged 1 commit into from
Feb 1, 2024

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Feb 1, 2024 •
edited
Loading

The r4 register is callee saved, it should be preserved. This caused crashes in Release builds.

Contributes to #97729

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2024
@ghost
Copy link

ghost commented Feb 1, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The r4 register is callee saved, it should be preserved. This caused crashes in Release builds.

Author: filipnavara
Assignees: -
Labels:

community-contribution, area-NativeAOT-coreclr
Milestone: -

jkotas
jkotas approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 72e1ece into dotnet:main Feb 1, 2024
105 of 110 checks passed
@build-analysis build-analysis bot mentioned this pull request Feb 1, 2024
Open
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @jkotas