Patch libunwind to hotfix validation pipe creation race #97817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
A change in libunwind 1.8.0 libunwind/libunwind#536 has introduced a race in one of its commits (libunwind/libunwind@ec03043) This race causes relatively rare unwind failures when multiple threads race for an initialization of a pipe that is used to verify that a memory address is accessible. This change reverts the change in the affected file. Once a proper fix is made in the libunwind, this patch would be reverted and the real fix applied. This issue is currently blocking source build and the new exception handling enabling by default.
janvorli
force-pushed
the
patch-libunwind-to-fix-pipe-race
branch
from
b2dd639
to
0f52f33
Compare
This was referenced Feb 1, 2024
|
@AaronRobinsonMSFT could you please approve this PR? |
AaronRobinsonMSFT
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in libunwind 1.8.0 (libunwind/libunwind#536) has introduced a race in one of its commits
(libunwind/libunwind@ec03043) This race causes relatively rare unwind failures when multiple
threads race for an initialization of a pipe that is used to verify that a memory address is accessible.
This change reverts the change in the affected file. Once a proper fix is made in the libunwind, this
patch would be reverted and the real fix applied.
This issue is currently blocking source build and the new exception handling enabling by default.