Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][jit] Fix the alignment of stack slots used to pass HFA argumen… #98279

Closed
wants to merge 1 commit into from

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Feb 11, 2024

…ts on arm64.

Vector3 was assumed to have size 16 and alignment 8, which caused problems when calling llvm compiled methods which assumed it was 12/8.

Fixes #96051.

Previously, different sizes/alignment where used in the pinvoke/non-pinvoke cases, causing problems with calling llvm compiled methods which always

@vargaz
Copy link
Contributor Author

vargaz commented Feb 11, 2024

/azp run runtime-ioslike

@vargaz
Copy link
Contributor Author

vargaz commented Feb 11, 2024

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…ts on arm64.

Vector3 was assumed to have size 16 and alignment 8, which caused problems when
calling llvm compiled methods which assumed it was 12/8.

Fixes dotnet#96051.

Previously, different sizes/alignment where used in the pinvoke/non-pinvoke
cases, causing problems with calling llvm compiled methods which always
@vargaz
Copy link
Contributor Author

vargaz commented Feb 23, 2024

/azp run runtime-ioslike

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz closed this Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] Failing runtime JIT/SIMD/Vector3Interop_r/ro tests on osx-arm64.
1 participant