Ensure the assert in IsEmbMaskOp is correct #98306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe
|
|
CC. @BruceForstall, this fixes the feedback given in #97675 (comment) |
BruceForstall
approved these changes
Feb 12, 2024
tannergooding
force-pushed
the
feedback-97675
branch
from
94d6d9d
to
0f5a211
Compare
tannergooding
commented
Feb 12, 2024
| bool result = (gtFlags & GTF_HW_EM_OP) != 0; | ||
| assert(!result || (gtOper == GT_HWINTRINSIC)); | ||
| return result; | ||
| return OperIsHWIntrinsic() && ((gtFlags & GTF_HW_EM_OP) != 0); |
There was a problem hiding this comment.
None of the callsites were checking OperIsHWIntrinsic() first, so needed to make the check explicit.
Asserting in MakeEmbMaskOp was then appropriate since it did check first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsEmbMaskOpAPI is only expected to be called forGT_HWINTRINSICnodes since it reuses bits valid for specific other node kinds.