Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler multiple test #98685

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix profiler multiple test #98685

merged 1 commit into from
Feb 21, 2024

Conversation

davmason
Copy link
Member

Fixes #98500

Wait for all three profilers to detach before exiting

@davmason davmason added this to the 9.0.0 milestone Feb 20, 2024
@davmason davmason requested a review from a team February 20, 2024 07:56
@davmason davmason self-assigned this Feb 20, 2024
@ghost
Copy link

ghost commented Feb 20, 2024

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #98500

Wait for all three profilers to detach before exiting

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr

Milestone: 9.0.0

@mdh1418
Copy link
Member

mdh1418 commented Feb 20, 2024

Out of curiosity, why was this test not failing before last week? Did something change a week ago that made the 3rd profiler request detach?

@davmason
Copy link
Member Author

Out of curiosity, why was this test not failing before last week? Did something change a week ago that made the 3rd profiler request detach?

I don't have a reason unfortunately. Looking at the crash dumps the failure was clear, but I have no clue why it wasn't happening until recently.

@lewing lewing merged commit 3338d4a into dotnet:main Feb 21, 2024
101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception. System.Exception: Profilee returned exit code 139 instead of expected exit code 100
3 participants