-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] Fix Promise cancelation #99397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
labels
Mar 7, 2024
This was referenced Mar 7, 2024
- testing if the promise hoilder is already disposed - added `exit` to `RuntimeAPI` - unregister from `FinalizationRegistry` in `upgrade_managed_proxy_to_strong_ref` - improve `BlazorHosted` WBT exit
pavelsavara
force-pushed
the
browser_mt_gc_handle
branch
from
March 7, 2024 12:10
8d93f93
to
ee24988
Compare
ilonatommy
approved these changes
Mar 8, 2024
src/mono/wasm/testassets/BlazorHostedApp/BlazorHosted.Client/Pages/Chat.razor
Outdated
Show resolved
Hide resolved
Please, filter out the noise in SignalR test log
|
This comment was marked as outdated.
This comment was marked as outdated.
- feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compareExchangeI32
🤦♂️FinalizationRegistry
inupgrade_managed_proxy_to_strong_ref
exit
toRuntimeAPI
BlazorHosted
WBT exitassert_runtime_running
always throw, in order to really protect the code after it.withAssertAfterExit
Contributes to #98721