Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0][browser] Fix failures in CalendarTestBase affecting several globalization tests #99407

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

ilonatommy
Copy link
Member

Fixes #99378.
On net9 the fix was provided in #90881, this PR is a partial backport.

Description

The failures are caused by changing v8 version. HybridGlobalization relies directly on v8's functions output, so with the version change these tests are prone to break. Currently we test on Linux with v8=12.4.105.

Customer Impact

Users that called globalization APIs connected with time with HybridGlobalization on and ja-JP locale and are using v8 newer than 11.8 are affected.

Regression

Yes, with older v8 the output is correct.

Testing

Existing automated unit tests.

Risk

Small, it impacts only one specific use-case.

@ilonatommy ilonatommy self-assigned this Mar 7, 2024
@ilonatommy ilonatommy added the Servicing-consider Issue for next servicing release review label Mar 7, 2024
@carlossanlop
Copy link
Member

I opened issues for the 3 the failures that showed up in the original CI run. They seem to be intermittent failures.

I also re-ran the failed legs and they now passed.

Just for my own peace of mind, @ilonatommy would you mind double checking this failure and confirm it's not related to this change or the one that caused this issue? #99423

@ilonatommy
Copy link
Member Author

ilonatommy commented Mar 8, 2024

Just for my own peace of mind, @ilonatommy would you mind double checking this failure and confirm it's not related to this change or the one that caused this issue? #99423

Based on the issue history it seems to be OOM problem, e.g. #60234. I do not see how adding that "if-condition" block in the code could cause OOM + it's not the only occurrence of this failure. We can treat it as unrelated.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 8, 2024
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop added this to the 8.0.4 milestone Mar 8, 2024
@carlossanlop carlossanlop merged commit 53e2082 into dotnet:release/8.0-staging Mar 8, 2024
120 of 121 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants