Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add missing Evidence types to AcccessControl NETFramework Facade #99462

Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Mar 8, 2024

Fixes #99447

Description

The AccessControl assembly is missing type forwards for Evidence and EvidenceBase on .NETFramework.

Customer Impact

Cannot use Evidence or EvidenceBase from a netstandard2.0 library and run on .NETFramework.

At compile time will see:

CS7069 Reference to type 'Evidence' claims it is defined in 'System.Security.AccessControl', but it could not be found

At runtime will see:

System.TypeLoadException : Could not load type 'System.Security.Policy.Evidence' from assembly 'System.Security.AccessControl, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

Regression

Yes, from 5.0 packages. See issue for RCA.

Testing

Manual, customer scenario + API Compat.

Risk

Very small. Simply adding type-forwards to the existing assembly.

This comment was marked as off-topic.

@ericstj ericstj added the Servicing-consider Issue for next servicing release review label Mar 8, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis teo-tsirpanis added this to the 6.0.x milestone Mar 8, 2024
@carlossanlop
Copy link
Member

The staging branches are currently open. Can you please retarget the PR to 6.0-staging?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending retargeting to the staging branch.

@ericstj ericstj changed the base branch from release/6.0 to release/6.0-staging March 8, 2024 19:53
@carlossanlop carlossanlop modified the milestones: 6.0.x, 6.0.29 Mar 12, 2024
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 12, 2024
@carlossanlop
Copy link
Member

Approved by Tactics via email. Will make sure to include it in today's flow to base.

@carlossanlop carlossanlop merged commit bc5e878 into dotnet:release/6.0-staging Mar 12, 2024
126 of 132 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants