-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use \e instead of \u001B or \x1B #99659
Conversation
Tagging subscribers to this area: @dotnet/area-meta |
Yaay :) |
@kouvel, FYI on the second commit. |
Some of the same changes were made by @jjonescz in 374a93f as part of PR #98559 which I thought was bringing in the relevant Roslyn changes. Are you hitting these issues already in the runtime repo? Maybe I missed something, anyway there might be conflicts between the two changes. |
I hadn't seen that PR. It looks like it's been stalled for a month, and also runs afoul of the versioning discussed above in #99659 (comment). @MichaelSimons,why is that auto-update PR not a problem for source build? |
It is a potential problem. If there are any dependencies taken on new functionality/breaking changes, it would break source-build. This flow should really only happen monthly. |
noticed it's missing from https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/strings/ but don't know how to mark that it's latest C# only. |
It's still preview (C# 13); we probably don't include preview features in that documentation yet? |
Oh, I don't know. fine. |
@lewing, @thaystg, the tests cited in #98559 (comment) are also failing here, which is also trying to bump the Roslyn toolset. If that test isn't failing anywhere else, it would appear it likely is related somehow. |
I'm trying to reproduce it locally. |
Fixed here: #99824 |
Small C# 13 nicety