[mono] Optimize mono_metadata_decode_row_col_raw #99939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
reviewed
Mar 19, 2024
vargaz
reviewed
Mar 19, 2024
vargaz
approved these changes
Mar 19, 2024
This was referenced Mar 19, 2024
lambdageek
reviewed
Mar 19, 2024
This was referenced Mar 19, 2024
lambdageek
approved these changes
Mar 20, 2024
lambdageek
reviewed
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop in this function is somewhat expensive, and in some wasm startup profiles I did we spent around 1% of cpu time inside it. From some quick tests this seems to make it a little bit faster, at the price of 9 bytes per MonoTableInfo (~500 bytes per assembly), which I think is worth it.