[NativeAOT-LLVM] support System.Net.Http.HttpClient on WASIp2

eng/pipelines/common/global-build-job.yml

@@ -232,6 +232,8 @@ jobs:
         displayName: Install wasi-sdk
       - script: pwsh $(Build.SourcesDirectory)/eng/pipelines/runtimelab/install-wasmtime.ps1 -CI -InstallDir $(Build.SourcesDirectory)/wasm-tools
         displayName: Install wasmtime
+      - script: pwsh $(Build.SourcesDirectory)/eng/pipelines/runtimelab/install-jco.ps1 $(Build.SourcesDirectory)
+        displayName: Install Jco
 
     - ${{ if or(eq(parameters.platform, 'browser_wasm_win'), and(eq(parameters.platform, 'wasi_wasm_win'), not(eq(parameters.runtimeFlavor, 'coreclr')))) }}:
       # Update machine certs

eng/pipelines/runtimelab/install-jco.ps1

@@ -0,0 +1,9 @@
+$RootPath = $Args[0]
+
+$NpmExePath = $Env:NPM_EXECUTABLE
+
+Set-Location -Path $RootPath
+
+& $NpmExePath install @bytecodealliance/jco
+& $NpmExePath install @bytecodealliance/preview2-shim
+

eng/pipelines/runtimelab/install-nodejs.ps1

@@ -51,11 +51,13 @@ if ($IsWindows)
 {
     Expand-Archive -LiteralPath "$InstallPath\$NodeJSZipName" -DestinationPath $InstallPath -Force
     $NodeJSExePath = "$InstallPath\$NodeJSInstallName\node.exe"
+    $NpmExePath = "$InstallPath\$NodeJSInstallName\npm.cmd"
 }
 else
 {
     tar xJf $InstallPath/$NodeJSZipName -C $InstallPath
     $NodeJSExePath = "$InstallPath/$NodeJSInstallName/bin/node"
+    $NpmExePath = "$InstallPath/$NodeJSInstallName/bin/npm"
 }
 
 if (!(Test-Path $NodeJSExePath))
@@ -64,5 +66,14 @@ if (!(Test-Path $NodeJSExePath))
     exit 1
 }
 
+if (!(Test-Path $NpmExePath))
+{
+    Write-Error "Did not find NPM at: '$NpmExePath'"
+    exit 1
+}
+
 Write-Host Setting NODEJS_EXECUTABLE to $NodeJSExePath
 Write-Host "##vso[task.setvariable variable=NODEJS_EXECUTABLE]$NodeJSExePath"
+
+Write-Host Setting NPM_EXECUTABLE to $NpmExePath
+Write-Host "##vso[task.setvariable variable=NPM_EXECUTABLE]$NpmExePath"

eng/testing/FindWasmHostExecutable.sh

@@ -6,7 +6,6 @@ exename=$(basename "$exename" .js)
 dirname=$(dirname "$1")
 
 node="node --stack_trace_limit=100"
-WASM_HOST_ARGS_SEPERATOR=""
 
 if [ -e "${dirname}/${exename}.js" ]; then
   WASM_HOST_EXECUTABLE=$node
@@ -21,7 +20,9 @@ elif [ -e "${dirname}/main.mjs" ]; then
   WASM_HOST_EXECUTABLE=$node
   WASM_BINARY_TO_EXECUTE="${dirname}/main.mjs"
 elif [ -e "${dirname}/${exename}.wasm" ]; then
-  WASM_HOST_EXECUTABLE=$WASMTIME_EXECUTABLE
-  WASM_HOST_ARGS_SEPERATOR="--"
+  if [ -z "$WASMTIME_EXECUTABLE" ]; then
+    WASMTIME_EXECUTABLE=wasmtime
+  fi
+  WASM_HOST_EXECUTABLE="$WASMTIME_EXECUTABLE run -S http"
   WASM_BINARY_TO_EXECUTE="${dirname}/${exename}.wasm"
 fi

eng/testing/FindWasmHostExecutableAndRun.sh

@@ -6,8 +6,8 @@ source $SCRIPT_DIR/FindWasmHostExecutable.sh "$1"
 
 if [ -n "${WASM_HOST_EXECUTABLE}" ]; then
   shift
-  echo $WASM_HOST_EXECUTABLE "$WASM_BINARY_TO_EXECUTE" $WASM_HOST_ARGS_SEPERATOR "$@"
-  $WASM_HOST_EXECUTABLE "$WASM_BINARY_TO_EXECUTE" $WASM_HOST_ARGS_SEPERATOR "$@"
+  echo $WASM_HOST_EXECUTABLE "$WASM_BINARY_TO_EXECUTE" "$@"
+  $WASM_HOST_EXECUTABLE "$WASM_BINARY_TO_EXECUTE" "$@"
 else
   echo WASM_HOST_EXECUTABLE not set.
   exit 1

src/coreclr/build-runtime.cmd

@@ -349,9 +349,11 @@ for /f "delims=" %%a in ("-%__RequestedBuildComponents%-") do (
         set __CMakeTarget=!__CMakeTarget! nativeaot
 
         if "%__TargetArch%"=="wasm" (
-            if not defined EMSDK (
-                echo %__ErrMsgPrefix%%__MsgPrefix%Error: The EMSDK environment variable pointing to emsdk root must be set.
-                goto ExitWithError
+            if "%__TargetOS%"=="browser" (
+                if not defined EMSDK (
+                    echo %__ErrMsgPrefix%%__MsgPrefix%Error: The EMSDK environment variable pointing to emsdk root must be set.
+                    goto ExitWithError
+                )
             )
         )
     )

src/coreclr/jit/compiler.cpp

@@ -9686,7 +9686,7 @@ void dumpConvertedVarSet(Compiler* comp, VARSET_VALARG_TP vars)
             {
                 printf(" ");
             }
-            printf("V%02u", varNum);
+            printf("V%02u", (unsigned int) varNum);
             first = false;
         }
     }

src/coreclr/jit/llvmlssa.cpp

@@ -1639,6 +1639,7 @@ class ShadowStackAllocator
 #ifdef __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wformat-security"
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 #endif // __clang__
             if (pBuffer == nullptr)
             {

src/coreclr/nativeaot/Runtime/Portable/CMakeLists.txt

@@ -40,4 +40,3 @@ install_static_library(standalonegc-disabled aotsdk nativeaot)
 if (NOT CLR_CMAKE_TARGET_ARCH_WASM)
   install_static_library(standalonegc-enabled aotsdk nativeaot)
 endif()
-

src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs

@@ -163,8 +163,8 @@ internal PhysicalFilesWatcher CreateFileWatcher()
 
             FileSystemWatcher? watcher;
 #if NET
-            //  For browser/iOS/tvOS we will proactively fallback to polling since FileSystemWatcher is not supported.
-            if (OperatingSystem.IsBrowser() || (OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) || OperatingSystem.IsTvOS())
+            //  For WASI/browser/iOS/tvOS we will proactively fallback to polling since FileSystemWatcher is not supported.
+            if (OperatingSystem.IsWasi() || OperatingSystem.IsBrowser() || (OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) || OperatingSystem.IsTvOS())
             {
                 UsePollingFileWatcher = true;
                 UseActivePolling = true;

src/libraries/Microsoft.Extensions.Hosting/src/Internal/ConsoleLifetime.netcoreapp.cs

@@ -15,10 +15,13 @@ public partial class ConsoleLifetime : IHostLifetime
 
         private partial void RegisterShutdownHandlers()
         {
-            Action<PosixSignalContext> handler = HandlePosixSignal;
-            _sigIntRegistration = PosixSignalRegistration.Create(PosixSignal.SIGINT, handler);
-            _sigQuitRegistration = PosixSignalRegistration.Create(PosixSignal.SIGQUIT, handler);
-            _sigTermRegistration = PosixSignalRegistration.Create(PosixSignal.SIGTERM, handler);
+            if (!OperatingSystem.IsWasi())
+            {
+                Action<PosixSignalContext> handler = HandlePosixSignal;
+                _sigIntRegistration = PosixSignalRegistration.Create(PosixSignal.SIGINT, handler);
+                _sigQuitRegistration = PosixSignalRegistration.Create(PosixSignal.SIGQUIT, handler);
+                _sigTermRegistration = PosixSignalRegistration.Create(PosixSignal.SIGTERM, handler);
+            }
         }
 
         private void HandlePosixSignal(PosixSignalContext context)
@@ -31,9 +34,12 @@ private void HandlePosixSignal(PosixSignalContext context)
 
         private partial void UnregisterShutdownHandlers()
         {
-            _sigIntRegistration?.Dispose();
-            _sigQuitRegistration?.Dispose();
-            _sigTermRegistration?.Dispose();
+            if (!OperatingSystem.IsWasi())
+            {
+                _sigIntRegistration?.Dispose();
+                _sigQuitRegistration?.Dispose();
+                _sigTermRegistration?.Dispose();
+            }
         }
     }
 }

src/libraries/System.Net.Http/src/System.Net.Http.csproj

@@ -462,7 +462,7 @@
   </ItemGroup>
 
   <!-- TODO-LLVM: This is not upstreamable because it makes the build runtime-specific. -->
-  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'wasi' and '$(RuntimeFlavor)' != 'CoreCLR'">
+  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'wasi'">
     <Reference Include="System.Threading.Thread" />
     <Compile Include="System\Net\Http\WasiHttpHandler\WasiHttpHandler.cs" />
     <Compile Include="System\Net\Http\WasiHttpHandler\WasiHttp.cs" />
@@ -532,5 +532,4 @@
   <ItemGroup>
     <None Include="Resources\SR.resx" />
   </ItemGroup>
-
 </Project>

src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs

@@ -11,7 +11,7 @@
 using System.Threading.Tasks;
 using System.Diagnostics.Metrics;
 // TODO-LLVM: This is not upstreamable and should be deleted when https://github.com/dotnet/runtimelab/pull/2614 is merged
-#if TARGET_WASI && !NATIVE_AOT
+#if TARGET_WASI
 using System.Diagnostics;
 using System.Net.Http.Metrics;
 using HttpHandlerType = System.Net.Http.WasiHttpHandler;
@@ -30,7 +30,7 @@ public partial class HttpClientHandler : HttpMessageHandler
         private readonly HttpHandlerType _underlyingHandler;
 
 // TODO-LLVM: This is not upstreamable and !NATIVE_AOT should be reverted when https://github.com/dotnet/runtimelab/pull/2614 is merged
-#if TARGET_BROWSER || (TARGET_WASI && !NATIVE_AOT)
+#if TARGET_BROWSER || TARGET_WASI
         private IMeterFactory? _meterFactory;
         private HttpMessageHandler? _firstHandler; // DiagnosticsHandler or MetricsHandler, depending on global configuration.
 
@@ -101,7 +101,7 @@ protected override void Dispose(bool disposing)
         public IMeterFactory? MeterFactory
         {
 // TODO-LLVM: This is not upstreamable and !NATIVE_AOT should be reverted when https://github.com/dotnet/runtimelab/pull/2614 is merged
-#if TARGET_BROWSER || (TARGET_WASI && !NATIVE_AOT)
+#if TARGET_BROWSER || TARGET_WASI
             get => _meterFactory;
             set
             {

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs

@@ -36,7 +36,7 @@ private void CheckDisposedOrStarted()
         /// Gets a value that indicates whether the handler is supported on the current platform.
         /// </summary>
         [UnsupportedOSPlatformGuard("browser")]
-        public static bool IsSupported => !OperatingSystem.IsBrowser();
+        public static bool IsSupported => !(OperatingSystem.IsBrowser() || OperatingSystem.IsWasi());
 
         public bool UseCookies
         {

src/libraries/System.Net.Http/src/System/Net/Http/WasiHttpHandler/WasiHttpHandler.cs

@@ -242,7 +242,7 @@ CancellationToken cancellationToken
                 await Task.WhenAll(
                         new Task<ITypes.IncomingResponse?>[]
                         {
-                            SendRequestAsync(outgoingRequest),
+                            SendRequestAsync(outgoingRequest, cancellationToken),
                             sendContent()
                         }
                     )
@@ -279,7 +279,8 @@ await Task.WhenAll(
         }
 
         private static async Task<ITypes.IncomingResponse?> SendRequestAsync(
-            ITypes.OutgoingRequest request
+            ITypes.OutgoingRequest request,
+            CancellationToken cancellationToken
         )
         {
             ITypes.FutureIncomingResponse future;
@@ -314,7 +315,8 @@ ITypes.OutgoingRequest request
                 }
                 else
                 {
-                    await RegisterWasiPollable(future.Subscribe()).ConfigureAwait(false);
+                    await RegisterWasiPollable(future.Subscribe(), cancellationToken)
+                        .ConfigureAwait(false);
                 }
             }
         }
@@ -461,7 +463,10 @@ private static async Task SendContentAsync(HttpContent? content, Stream stream)
             }
         }
 
-        private static Task RegisterWasiPollable(IPoll.Pollable pollable)
+        private static Task RegisterWasiPollable(
+            IPoll.Pollable pollable,
+            CancellationToken cancellationToken
+        )
         {
             var handle = pollable.Handle;
 
@@ -470,12 +475,15 @@ private static Task RegisterWasiPollable(IPoll.Pollable pollable)
             pollable.Handle = 0;
             GC.SuppressFinalize(pollable);
 
-            return CallRegisterWasiPollableHandle((Thread)null!, handle);
-
+            return CallRegisterWasiPollableHandle((Thread)null!, handle, cancellationToken);
         }
 
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod, Name = "RegisterWasiPollableHandle")]
-        private static extern Task CallRegisterWasiPollableHandle(Thread t, int handle);
+        private static extern Task CallRegisterWasiPollableHandle(
+            Thread t,
+            int handle,
+            CancellationToken cancellationToken
+        );
 
         private sealed class InputStream : Stream
         {
@@ -562,7 +570,7 @@ CancellationToken cancellationToken
                             var buffer = result;
                             if (buffer.Length == 0)
                             {
-                                await RegisterWasiPollable(stream.Subscribe())
+                                await RegisterWasiPollable(stream.Subscribe(), cancellationToken)
                                     .ConfigureAwait(false);
                             }
                             else
@@ -699,7 +707,8 @@ CancellationToken cancellationToken
                     var count = (int)stream.CheckWrite();
                     if (count == 0)
                     {
-                        await RegisterWasiPollable(stream.Subscribe()).ConfigureAwait(false);
+                        await RegisterWasiPollable(stream.Subscribe(), cancellationToken)
+                            .ConfigureAwait(false);
                     }
                     else if (offset == limit)
                     {

src/libraries/System.Net.NameResolution/src/System.Net.NameResolution.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser;$(NetCoreAppCurrent)</TargetFrameworks>
+    <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser;$(NetCoreAppCurrent)-wasi;$(NetCoreAppCurrent)</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile>
   </PropertyGroup>
@@ -68,7 +68,7 @@
              Link="Common\Interop\Windows\WinSock\Interop.GetAddrInfoExW.cs" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix'">
+  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix' or '$(TargetPlatformIdentifier)' == 'wasi'">
     <Compile Include="System\Net\NameResolutionPal.Unix.cs" />
     <Compile Include="$(CommonPath)System\Net\InteropIPAddressExtensions.Unix.cs"
              Link="Common\System\Net\InteropIPAddressExtensions.Unix.cs" />

src/libraries/System.Net.Sockets/src/System.Net.Sockets.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-osx;$(NetCoreAppCurrent)-ios;$(NetCoreAppCurrent)-tvos;$(NetCoreAppCurrent)</TargetFrameworks>
+    <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-wasi;$(NetCoreAppCurrent)-osx;$(NetCoreAppCurrent)-ios;$(NetCoreAppCurrent)-tvos;$(NetCoreAppCurrent)</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <!-- SYSTEM_NET_SOCKETS_DLL is required to allow source-level code sharing for types defined within the
          System.Net.Internals namespace. -->
@@ -183,7 +183,7 @@
              Link="Common\System\Net\CompletionPortHelper.Windows.cs" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix' or '$(TargetPlatformIdentifier)' == 'osx' or '$(TargetPlatformIdentifier)' == 'ios' or '$(TargetPlatformIdentifier)' == 'tvos'">
+  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix' or '$(TargetPlatformIdentifier)' == 'osx' or '$(TargetPlatformIdentifier)' == 'ios' or '$(TargetPlatformIdentifier)' == 'tvos' or '$(TargetPlatformIdentifier)' == 'wasi'">
     <Compile Include="System\Net\Sockets\SafeSocketHandle.Unix.cs" />
     <Compile Include="System\Net\Sockets\Socket.Unix.cs" />
     <Compile Include="System\Net\Sockets\SocketAsyncContext.Unix.cs" />

src/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs

@@ -481,6 +481,10 @@ public bool Wait(int millisecondsTimeout)
 #endif
         public bool Wait(int millisecondsTimeout, CancellationToken cancellationToken)
         {
+#if TARGET_WASI
+            _ = s_cancellationTokenCallback;
+            throw new PlatformNotSupportedException("ManualResetEventSlim.Wait not supported on WASI");
+#else // not TARGET_WASI
             ObjectDisposedException.ThrowIf(IsDisposed, this);
             cancellationToken.ThrowIfCancellationRequested(); // an early convenience check
 
@@ -592,6 +596,7 @@ public bool Wait(int millisecondsTimeout, CancellationToken cancellationToken)
             } // automatically disposes (and unregisters) the callback
 
             return true; // done. The wait was satisfied.
+#endif // not TARGET_WASI
         }
 
         /// <summary>

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.Unix.cs

@@ -13,9 +13,9 @@ public sealed partial class Thread
     {
         // these methods are temporarily accessed via UnsafeAccessor from generated code until we have it in public API, probably in WASI preview3 and promises
 #if TARGET_WASI
-        internal static System.Threading.Tasks.Task RegisterWasiPollableHandle(int handle)
+        internal static System.Threading.Tasks.Task RegisterWasiPollableHandle(int handle, CancellationToken cancellationToken)
         {
-            return WasiEventLoop.RegisterWasiPollableHandle(handle);
+            return WasiEventLoop.RegisterWasiPollableHandle(handle, cancellationToken);
         }
 
         internal static int PollWasiEventLoopUntilResolved(Task<int> mainTask)
@@ -33,6 +33,10 @@ internal static int PollWasiEventLoopUntilResolved(Task<int> mainTask)
             return mainTask.Result;
         }
 
+        internal static void DispatchWasiEventLoop()
+        {
+            WasiEventLoop.DispatchWasiEventLoop();
+        }
 #endif
 
         // the closest analog to Sleep(0) on Unix is sched_yield