Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WCF sample Compression Encoder code to conditionally support NET framework / Core #6282

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afifi-ins
Copy link
Contributor

No description provided.

@@ -20,68 +19,73 @@ static class GZipMessageEncodingPolicyConstants
}

//This is the binding element that, when plugged into a custom binding, will enable the GZip encoder
#if NET462_OR_GREATER
public sealed class GZipMessageEncodingBindingElement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can simplify with a single #if block

    public sealed class GZipMessageEncodingBindingElement 
                        : MessageEncodingBindingElement //BindingElement
#if NET462_OR_GREATER
                        , IPolicyExportExtension
#endif

@afifi-ins afifi-ins force-pushed the WcfSamplesUpgrade/CompressionMessageEncoder branch from 213e27b to 3c9039b Compare November 2, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants