Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build locates restore files in BaseIntermediateOutputPath instead of RestoreOutputPath #1486

Closed
jkoritzinsky opened this issue Aug 14, 2017 · 2 comments
Closed

Build locates restore files in BaseIntermediateOutputPath instead of RestoreOutputPath #1486

jkoritzinsky opened this issue Aug 14, 2017 · 2 comments
Assignees
@dsplaisted @livarcocc
Labels
In PR Urgency-Soon
Milestone
2.1.3xx

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Aug 14, 2017 •
edited
Loading

Relevant source:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.PackageDependencyResolution.targets

Line 28 in 98ea6b2

<ProjectAssetsFile Condition="'$(ProjectAssetsFile)' == ''">$(BaseIntermediateOutputPath)/project.assets.json</ProjectAssetsFile>

If a user uses the RestoreOutputPath property to change the output path, dotnet restore will put the project.assets.json in that path. dotnet build will fail to find the assets file if RestoreOutputPath is does not resolve to the same location as BaseIntermediateOutputPath.
@dasMulli
Copy link
Contributor

fyi there's a related SO question: https://stackoverflow.com/questions/45575280/msbuild-nuget-restoreoutputpath-how-to-make-it-work

@Zastai Zastai mentioned this issue Aug 18, 2017
Closed
@livarcocc livarcocc added this to the 2.2.0 milestone Jan 19, 2018
@livarcocc livarcocc self-assigned this Jan 19, 2018
@dsplaisted dsplaisted self-assigned this Feb 21, 2018
dsplaisted added a commit to dsplaisted/sdk that referenced this issue Mar 1, 2018
@dsplaisted
Don't set a default ProjectAssetsFile path in the SDK
8f20154 
Resolves dotnet#1486
@dsplaisted dsplaisted mentioned this issue Mar 1, 2018
Merged
dsplaisted added a commit to dsplaisted/sdk that referenced this issue Apr 13, 2018
@dsplaisted
Don't set a default ProjectAssetsFile path in the SDK
364c525 
Resolves dotnet#1486
@dsplaisted
Copy link
Member

Fixed with NuGet/NuGet.Client#2131 and dotnet/msbuild#3059. The property to use is now MSBuildProjectExtensionsPath.

dsplaisted added a commit to dsplaisted/sdk that referenced this issue Apr 19, 2018
@dsplaisted
Don't set a default ProjectAssetsFile path in the SDK
4611d36 
Resolves dotnet#1486
mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
286e2a9 
…0200529.12 (dotnet#1486)

Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers
 From Version 5.0.0-preview.6.20278.12 -> To Version 5.0.0-preview.6.20279.12

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
@mlorbetske
Merge pull request dotnet#1486 from dotnet/master
dedfafb 
Merge loc handbacks from master into stabilize
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
@mlorbetske
Merge pull request dotnet#1486 from dotnet/master
4ad1753 
Merge loc handbacks from master into stabilize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsplaisted dsplaisted

@livarcocc livarcocc

Labels
In PR Urgency-Soon
Projects
None yet
Milestone
2.1.3xx
Development

No branches or pull requests
4 participants
@dsplaisted @livarcocc @jkoritzinsky @dasMulli