Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roslyn-analyzers version and remove false-positive suppressions #28672

Closed
333fred opened this issue Oct 20, 2022 · 4 comments
Closed

Update roslyn-analyzers version and remove false-positive suppressions #28672

333fred opened this issue Oct 20, 2022 · 4 comments
Labels
Area-NetSDK untriaged Request triage from a team member
Milestone
8.0.1xx

Comments

@333fred
Copy link
Member

333fred commented Oct 20, 2022

#28520 and #28519 brought a new roslyn compiler that needs an update for roslyn-analyzers to avoid false positives in a few analyzers. See #28520 (comment).
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Oct 20, 2022
333fred added a commit that referenced this issue Oct 20, 2022
@333fred
Suppress false positives. Updating analyzers is tracked by #28672.
960fda4
333fred added a commit that referenced this issue Oct 20, 2022
@333fred
Suppress false positives. Updating analyzers is tracked by #28672.
06b2509
@333fred
Copy link
Member Author

333fred commented Oct 20, 2022

@marcpopMSFT FYI.

@marek-safar marek-safar added this to the 8.0.1xx milestone Oct 20, 2022
dotnet-maestro bot added a commit that referenced this issue Oct 20, 2022
@dotnet-maestro
[main] Update dependencies from dotnet/roslyn (#28520)
3a31c64 
[main] Update dependencies from dotnet/roslyn


 - Suppress false positives. Updating analyzers is tracked by #28672.
@marcpopMSFT
Copy link
Member

@333fred is anything still needed to complete and close this issue? This was from a year ago and listed for 8.0.1xx

@333fred
Copy link
Member Author

333fred commented Sep 16, 2023

@marcpopMSFT have the false positive suppressions I had to add in the linked pr been removed?

@marcpopMSFT marcpopMSFT mentioned this issue Sep 18, 2023
Merged
@marcpopMSFT
Copy link
Member

@333fred oh, you filed this because those needed to be removed later. I thought this was tracking that an upstream change was needed as I had misread your phrasing in the original issue. Created a PR to remove all those pragma statements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Milestone
8.0.1xx
Development

No branches or pull requests
3 participants
@marek-safar @333fred @marcpopMSFT