Add default VB properties for nowarn, warninglevel and msbuildAllProjects #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivatsn
approved these changes
Apr 15, 2017
|
Change LGTM. You need to rebase to the rel/1.0.0 branch. |
|
@srivatsn , I just forgot to add it. I have added them. |
|
I thought there will be a different branch(branched from rel1.0.0) for Dev15.3 Preview1. Are we going to use rel1.0.0? @srivatsn @livarcocc |
basoundr
force-pushed
the
VBDefaultProperty
branch
from
b5e8f9b
to
3eafb40
Compare
The options are OptionExplicit, OptionCompare, OptionStrict and OptionInfer
basoundr
force-pushed
the
VBDefaultProperty
branch
from
3eafb40
to
93fd8be
Compare
|
tagging @MattGertz for approval |
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jun 7, 2022
Fixes dotnet#1132 Fixes dotnet#1128 Fixes dotnet#1127 Fixes dotnet#1126 Fixes dotnet#1125 Fixes dotnet#1124 Fixes dotnet#1115
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jul 11, 2022
Fixes dotnet#1132 Fixes dotnet#1128 Fixes dotnet#1127 Fixes dotnet#1126 Fixes dotnet#1125 Fixes dotnet#1124 Fixes dotnet#1115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds default value for VB msbuild properties that are required to light up the compile page. The corresponding change in Project system is project-system/2004
This change should go into the Dev15.3 Preview1 branch and not the alpha pack branch. I will retarget the branch once @livarcocc creates the Dev15.3 Preview1 branch.
@davkean @srivatsn @dotnet/project-system for review
Customer scenario
Enables the VB Compile Property page by providing the default VB values
Bugs this fixes:
#346
Workarounds, if any
None
Risk
Low risk - since this just affects that page and adds new properties
Performance impact
None - since this just adds some properties
Is this a regression from a previous update? N/A
Root cause analysis: N/A
How was the bug found? N/A