Update SDK to support new DI and Attribute feature switches #19432
Conversation
eerhardt
requested review from
pranavkm,
sbomer,
captainsafia,
LakshanF and
vitek-karas
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| @@ -47,6 +47,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">true</UseSystemResourceKeys> | |||
| <EnableUnsafeUTF7Encoding Condition="'$(EnableUnsafeUTF7Encoding)' == ''">false</EnableUnsafeUTF7Encoding> | |||
| <HttpActivityPropagationSupport Condition="'$(HttpActivityPropagationSupport)' == ''">false</HttpActivityPropagationSupport> | |||
| <NullabilityInfoContextSupport Condition="'$(NullabilityInfoContextSupport)' == ''">false</NullabilityInfoContextSupport> | |||
| <_AggressiveAttributeTrimming Condition="'$(_AggressiveAttributeTrimming)' == ''">true</_AggressiveAttributeTrimming> | |||
There was a problem hiding this comment.
Is this "private" because we don't think it's ready for prime time?
There was a problem hiding this comment.
Right. It is a bit dangerous removing all these attributes as some code could be reading them, and now behavior has changed. To mitigate this, we are making this setting "private" for Blazor WASM (and Maui if needed) to use to get as small as possible, but we don't expect other app models to use this.
With dotnet/runtime#56475, Blazor WASM devs who are broke by the attribute trimming can now turn it off to get unblocked, at the cost of a slightly larger app.
See
@pranavkm @captainsafia - note the changes to the Blazor WASM targets file.