Update application insights version #22974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpopMSFT
force-pushed
the
marcpopMSFT-updateappinsights
branch
from
4c40195
to
e56a02c
Compare
|
See microsoft/ApplicationInsights-dotnet#1152 for more details on this change. Unfortunately, I'm missing context on telemetry to be sure the fix is correct. |
dsplaisted
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Per this comment
Keep one
TelemetryConfigurationper app lifetime (a few is also fine), but you may create as many clients as you want.
Do not forget to disposeTelemetryConfigurationwhen gracefully shutting down the application.
It looks like we're not doing that here, and probably we should be.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…o have noticeable impact on functionality.
dsplaisted
approved these changes
Feb 2, 2022
marcpopMSFT
added a commit
that referenced
this pull request
Jul 11, 2022
Update application insights version
marcpopMSFT
added a commit
that referenced
this pull request
Aug 2, 2022
Merge pull request #22974 from dotnet/marcpopMSFT-updateappinsights
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.