Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For build-from-source builds of .NET, opt-out of Microsoft telemetry #25935

Merged
merged 8 commits into from
Aug 9, 2022
Merged

For build-from-source builds of .NET, opt-out of Microsoft telemetry #25935

merged 8 commits into from
Aug 9, 2022

Commits on Aug 9, 2022

  1. For build-from-source builds of .NET, opt-out of Microsoft telemetry … 

    …by default.

We opt-out by setting DOTNET_CLI_TELEMETRY_OPTOUT at 'dotnet' Main
to ensure that anything that checks the variable later, including MSBuild Tasks,
will see the value.
    @tmds @vlada-shubina
    tmds authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b831a98 View commit details
    Browse the repository at this point in the history

  2. Use const string also for existing check.

    @tmds @vlada-shubina
    tmds authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ec48946 View commit details
    Browse the repository at this point in the history

  3. Refactor to using the default value to control the opt-out.

    @tmds @vlada-shubina
    tmds authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d9a6074 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Rich Lander <[email protected]>
    @tmds @richlander @vlada-shubina
    2 people authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b5db7d6 View commit details
    Browse the repository at this point in the history

  5. Rename to OfficialBuilder, and set value to true in workflow.

    @tmds @vlada-shubina
    tmds authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    afb63ae View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Use 'Microsoft' as 'OfficialBuilder' value.

Co-authored-by: Jan Kotas <[email protected]>
    @tmds @jkotas @vlada-shubina
    2 people authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8126bbf View commit details
    Browse the repository at this point in the history

  7. Update Directory.Build.props

    @tmds @vlada-shubina
    tmds authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    6d2a16b View commit details
    Browse the repository at this point in the history

  8. Change Move Official builder into a separate build variable

    @marcpopMSFT @vlada-shubina
    marcpopMSFT authored and vlada-shubina committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2cd0f13 View commit details
    Browse the repository at this point in the history