-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RidSpecific, Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ #28412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SC not default implied
This reverts commit 7be2640.
nagilson
changed the title
8.0 Breaking Changes
Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+
Oct 10, 2022
Still blocked by #28563 |
nagilson
changed the title
Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+
Add RidSpecific, Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+
Oct 25, 2022
16 tasks
This is no longer blocked. |
@@ -61,6 +61,14 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
<RuntimeIdentifier Condition="'$(PlatformTarget)' == 'x86' or '$(PlatformTarget)' == ''">win7-x86</RuntimeIdentifier> | |||
</PropertyGroup> | |||
|
|||
<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and '$(OutputType)' == 'Exe'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and '$(OutputType)' == 'Exe'"> | |
<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and ('$(OutputType)' == 'Exe' or '$(OutputType)' == 'WinExe')"> |
We aren't doing this proposal anymore, there is a new proposal |
Where is that new proposal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #26031
7.0 backport #28376
Adds
RuntimeSpecific
:RuntimeSpecific
to false, but no opt-out to not implying SC with RIDs in TFM 8.0Based on .NET 8.0 Breaking Changes Notes:
Tested Behavior:
Questions:
TargetFrameworkInference
sometimes not run? I accounted for that, but don't understand the contexts.RidSpecific
by default ifRuntimeIdentifiers
is set? ATM, I made it soRuntimeSpecific
doesn't do anything ifRuntimeIdentifiers
is set, nor will apps with RuntimeIdentifiers be FDD.Verify:
Make sure you can still specify -r runtime without it being overriden.
Make sure you can still specify self-contained to true even if you do /p:SelfContained=true.