[main] Update dependencies from dotnet/runtime #28584

dotnet-maestro · 2022-10-14T12:21:39Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20221019.7
Date Produced: October 20, 2022 2:17:24 AM UTC
Commit: 6eb3ccb9507b74798c4bd3241587c4cf3b18866e
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.ILCompiler: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.Extensions.DependencyModel: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NET.HostModel: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NETCore.App.Ref: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- Microsoft.NETCore.Platforms: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- System.CodeDom: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- System.Reflection.MetadataLoadContext: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- System.Resources.Extensions: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- System.Security.Cryptography.ProtectedData: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- System.Text.Encoding.CodePages: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-alpha.1.22512.8 to 8.0.0-alpha.1.22519.7

…1013.13 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22513.13

dotnet-maestro · 2022-10-14T13:12:29Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

am11 · 2022-10-14T15:43:59Z

eng/Version.Details.xml

@@ -114,30 +114,30 @@
      <Sha>6000a84c7e0b3678af032c25b7319aefdd057f6c</Sha>
      <SourceBuild RepoName="linker" ManagedOnly="true" />
    </Dependency>
-    <Dependency Name="Microsoft.DotNet.ILCompiler" Version="8.0.0-alpha.1.22512.8">
+    <Dependency Name="Microsoft.DotNet.ILCompiler" Version="8.0.0-alpha.1.22513.13">


@jkotas, the ILCompiler package version being updated is 8.x. But the tests are trying to use binaries from 7.0.0-rc.1.22426.10 package, while picking Microsoft.NETCore.Native.targets from 8.0.100-ci and failing due to missing new files we recently added in 8.x https://helix.dot.net/api/2019-06-17/jobs/2c21a5b3-5b77-4883-ae23-f6a7b4c70305/workitems/Microsoft.NET.Publish.Tests.dll.2/console.

Should they use the same version for Microsoft.NETCore.Native.targets and the binaries? This mismatch of version is unsustainable.

@LakshanF Could you please look into this?

It is the kind of problem with versioning Microsoft.NETCore.Native.targets that I was worried about.

…1014.9 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22514.9

…1015.3 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22515.3

…1016.1 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22516.1

…1017.2 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22517.2

…1018.11 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22518.11

jeffschwMSFT · 2022-10-19T15:17:30Z

@LakshanF can you take a look? Thanks

am11 · 2022-10-20T02:21:18Z

Disabling linux testing until runtime dotnet/runtime#75468 is fixed

Instead of disabling all aot tests on linux, we can set -p:LinkStandardCPlusPlusLibrary=true until #28563 is completed, and then we can remove LinkStandardCPlusPlusLibrary=true to test with default settings.

dotnet/runtime#75468 will fix this issue permanently for different major versions (we basically need to defer the import of Microsoft.NETCore.Native.targets to the one in the matching version of ILComplier package, whose binaries we are going to consume / link with).

…1019.7 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22512.8 -> To Version 8.0.0-alpha.1.22519.7

…s://github.com/dotnet/sdk into darc-main-ea02237a-f937-463c-a5a2-ef46b098f7a2

src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs

am11 · 2022-10-20T13:26:34Z

There is another AOT test failing:

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishANetCoreAppForTelemetry.cs

Line 97 in a3d79dd

public void It_collects_Aot_publishing_properties(string targetFramework)

…AnAotApp.cs Co-authored-by: Jan Kotas <[email protected]>

agocke · 2022-10-20T17:50:52Z

src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishANetCoreAppForTelemetry.cs

+            if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                // Workaround for https://github.com/dotnet/runtime/issues/75468. Delete once the issue is fixed.
+                testProject.AdditionalProperties["LinkStandardCPlusPlusLibrary"] = "true";


Can we put this in the targets file instead? That way it will actually work, instead of just passing this test.

dotnet-issue-labeler bot added the Area-CodeFlow label Oct 14, 2022

am11 reviewed Oct 14, 2022

View reviewed changes

build-analysis bot mentioned this pull request Oct 15, 2022

Nuget restore error caused by 503s dotnet/arcade#11239

Closed

2 tasks

dotnet-maestro bot added 4 commits October 16, 2022 12:16

LakshanF added 2 commits October 19, 2022 15:47

Disabling linux testing until runtime #75468 is fixed

96af8be

removed debugging artifact

f4657e7

build-analysis bot mentioned this pull request Oct 20, 2022

Tracking Nuget 429s dotnet/arcade#10885

Closed

2 tasks

dotnet-maestro bot and others added 3 commits October 20, 2022 12:16

work around linux issue by using standard c lib

d4aa91a

Merge branch 'darc-main-ea02237a-f937-463c-a5a2-ef46b098f7a2' of http…

6c1c132

…s://github.com/dotnet/sdk into darc-main-ea02237a-f937-463c-a5a2-ef46b098f7a2

jkotas reviewed Oct 20, 2022

View reviewed changes

src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs Outdated Show resolved Hide resolved

LakshanF and others added 2 commits October 20, 2022 07:52

Update src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublish…

eada16e

…AnAotApp.cs Co-authored-by: Jan Kotas <[email protected]>

FB

621832c

agocke reviewed Oct 20, 2022

View reviewed changes

agocke self-assigned this Oct 20, 2022

Set LinkStandardCPlusPlusLibrary automatically on non-windows

c8b948c

agocke approved these changes Oct 20, 2022

View reviewed changes

agocke merged commit fe5db31 into main Oct 20, 2022

agocke deleted the darc-main-ea02237a-f937-463c-a5a2-ef46b098f7a2 branch October 20, 2022 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #28584

[main] Update dependencies from dotnet/runtime #28584

dotnet-maestro bot commented Oct 14, 2022 •

edited

Loading

dotnet-maestro bot commented Oct 14, 2022

am11 Oct 14, 2022

jkotas Oct 14, 2022

jeffschwMSFT commented Oct 19, 2022

am11 commented Oct 20, 2022

am11 commented Oct 20, 2022

agocke Oct 20, 2022

[main] Update dependencies from dotnet/runtime #28584

[main] Update dependencies from dotnet/runtime #28584

Conversation

dotnet-maestro bot commented Oct 14, 2022 • edited Loading

From https://github.com/dotnet/runtime

dotnet-maestro bot commented Oct 14, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

am11 Oct 14, 2022

Choose a reason for hiding this comment

jkotas Oct 14, 2022

Choose a reason for hiding this comment

jeffschwMSFT commented Oct 19, 2022

am11 commented Oct 20, 2022

am11 commented Oct 20, 2022

agocke Oct 20, 2022

Choose a reason for hiding this comment

dotnet-maestro bot commented Oct 14, 2022 •

edited

Loading