-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PublishRuntimeIdentifier #28717
Introduce PublishRuntimeIdentifier #28717
Conversation
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
@dsplaisted PTAL when you're free |
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
This reverts commit c6dbb25.
Co-authored-by: Daniel Plaisted <[email protected]>
438d643
to
36c3bc6
Compare
/azp run (GH is bugged due to rebase) |
Azure Pipelines successfully started running 1 pipeline(s). |
No pipelines are associated with this pull request. |
@dsplaisted PTAL. I've made all of the requested changes and a few others where the same comment applied to other parts. Let's merge this and then use this testProject change in the PublishSelfContained PR. |
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <[email protected]>
@dsplaisted Thanks for taking a look, I appreciate your time. I added some comments in the test code. As incorrect comments can be quite insidious, lmk if you see anything wrong. |
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
…into nagilson-publish-rid
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
… anyways Co-authored-by: Daniel Plaisted <[email protected]>
Changes Examples
dotnet publish --use-current-runtime -p:PublishRuntimeIdentifier=tizen
will publish with tizen, not the ucr.dotnet publish --self-contained -p:PublishRuntimeIdentifier=win-x86
will publish with rid: win-x86dotnet publish -p:PublishRuntimeIdentifier=win-x86
will publish with win-x86 rid.In a project file:
dotnet build
-> win-x86 rid.dotnet publish
-> win-x64 rid.dotnet publish -r win-x86 /p:PublishRuntimeIdentifier=tizen
will get rid: win-x86. Not ideal, we can do it the other way but it will have potentially far-reaching consequences.dotnet publish --property:RuntimeIdentifier=win-x86 /p:PublishRuntimeIdentifier=tizen
: gives win-x86 rid.Summary
PublishRuntimeIdentifier
will overrideRuntimeIdentifier
when publishing unless it is global, like passed in withdotnet publish --r RID /p:PulishRuntimeIdentifier=RID_2
PublishRuntimeIdentifier
will override the RID if UCR is used.The rest is pretty self explanatory...