[release/6.0.1xx] Backport Add Blazor SWA Baseline Mismatched Assets Logging #28894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Blazor AssetDifferencesDetails * Update AspNetSdkBaselineTest.cs For https://github.com/dotnet/sdk/issues/27346 * Spacing * Create blazor-swa-baseline-generation.md * PR Feedback * Remove instructions add script reference * Property level comparison * Added instructions * Update AspNetSdkBaselineTest.cs * Update AspNetSdkBaselineTest.cs (cherry picked from commit bacc17c)
TanayParikh
added
Area-AspNetCore
2 tasks
|
@marcpopMSFT fine to merge? |
|
The branch is open for changes and no tactics approval is needed for test changes. Will this make the tests more reliable? I assume you'll want Pr approval from someone else on your team to review but then merge whenever. |
javiercn
approved these changes
Nov 10, 2022
|
@marcpopMSFT this will make it easier to update the baselines. In parallel we are looking to see if we can "relax" the way we compare the baselines a bit to be more robust to changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #27542
Related: #28883