Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for starting the application through CMD (instead of ENTRYPOINT). #33037

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Add support for starting the application through CMD (instead of ENTRYPOINT). #33037

merged 10 commits into from
Jun 21, 2023

Commits on Jun 5, 2023

  1. Add support for starting the application through CMD (instead of ENTR… 

    …YPOINT).

The new ContainerAppCommand and ContainerAppCommandArgs properties are used to hold
the command line to start the application.

The ContainerAppCommandInstruction controls how the command line is emitted.

The default behavior is to emit an ENTRYPOINT when the base image has no ENTRYPOINT,
and a CMD when the base image has an ENTRYPOINT (to use the base image ENTRYPOINT).

This also adds a ContainerCmd property, which can be used to directly set the image CMD.
    @tmds
    tmds committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    71a6b33 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Handle images that set 'dotnet' as the ENTRYPOINT.

    @tmds
    tmds committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f58e8ee View commit details
    Browse the repository at this point in the history

  2. Add Log messages.

    @tmds
    tmds committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    a5bbde6 View commit details
    Browse the repository at this point in the history

  3. ContainerizeCommand: add '--cmd' for '--entrypointargs'.

    @tmds
    tmds committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    df67db8 View commit details
    Browse the repository at this point in the history

  4. Add missing quotes.

    @tmds
    tmds committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8e51b73 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'main' into app_command

    @tmds
    tmds authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    743fa71 View commit details
    Browse the repository at this point in the history

  2. Tweak DetermineEntrypointAndCmd behavior and add a test.

    @tmds
    tmds committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9b6a428 View commit details
    Browse the repository at this point in the history

  3. ContainerBuilder: rename arg from entrypointArgs to cmd.

    @tmds
    tmds committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2de9dc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Rename 'Cmd' to 'DefaultArgs' as it is more descriptive.

    @tmds
    tmds committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a2e801d View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Extend EntrypointAndCmd test to cover all branches.

    @tmds
    tmds committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    02e0740 View commit details
    Browse the repository at this point in the history