Add dependencies needed for source-build PVP flow #33039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CodeFlow
untriaged
26 tasks
mmitche
approved these changes
Jun 5, 2023
MichaelSimons
approved these changes
Jun 5, 2023
joeloff
reviewed
Jun 7, 2023
eng/Versions.props
Outdated
| <NuGetPackagingPackageVersion>6.7.0-preview.2.51</NuGetPackagingPackageVersion> | ||
| <NuGetVersioningPackageVersion>6.7.0-preview.2.51</NuGetVersioningPackageVersion> | ||
| <NuGetPackagingVersion>6.7.0-preview.2.51</NuGetPackagingVersion> | ||
| <NuGetProjectModelVersion>6.7.0-preview.2.51</NuGetProjectModelVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <!-- Dependencies from https://github.com/Microsoft/vstest --> | ||
| <MicrosoftNETTestSdkPackageVersion>17.7.0-preview.23302.1</MicrosoftNETTestSdkPackageVersion> |
There was a problem hiding this comment.
Since the version is explicitly used further down, do we still need the property?
There was a problem hiding this comment.
MicrosoftNETTestSdkPackageVersion is used in various places in this repo, we need this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
PVP flow is a method of flowing dependencies in source build that only overrides versions of packages that the repo has a declared dependency on in
Version.Details.xml. This means that the package flow is closer to the Microsoft's way of building .NET.To enable this for
sdk, we just need to add dependencies on the packages that should be overridden in source build. In this case, it's the variousnuget.clientand 2vstestpackages. I've also updatedVersions.propsfile to remove usage of proxy properties for these repos - this is needed for proper PVP flow.To fully enable PVP flow, the repo project in the VMR will needto set
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>once these changes flow in.