Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use cookies to unblock CSRF workflows #37221

Conversation

baronfel
Copy link
Member

Fixes dotnet/sdk-container-builds#418 (possibly)

Since Harbor enforces CSRF tokens we have to reject all uses of cookies to unblock our support of it. This seems to be what other registry clients do.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Nov 29, 2023
@baronfel
Copy link
Member Author

This has been tested and validated by @djheap here, so marking this up for review.

@baronfel baronfel requested a review from a team November 29, 2023 19:23
@baronfel baronfel merged commit a6c752a into dotnet:release/8.0.2xx Dec 18, 2023
16 checks passed
@baronfel baronfel deleted the remove-use-of-cookies-from-containers branch January 11, 2024 23:46
@Varorbc
Copy link

Varorbc commented Jan 17, 2024

@baronfel @MichalPavlik Can this issue be fixed in other versions as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants